Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render list properly in tutorial documentation #776

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Jan 19, 2022

A list in the third exercise didn't have a newline between the paragraph
and the items, causing it to render as a paragraph. This commit fixes
the list so it renders appropriately and wraps the lines at 80 after
reducing indentation.

@openshift-ci openshift-ci bot requested review from jhrozek and xiaojiey January 19, 2022 20:04
@mrogers950
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
Some of the lists in the walk-through didn't have newlines between the
lists and paragraphs, causing them to render incorrectly.
@rhmdnd rhmdnd force-pushed the cleanup-list-in-walkthrough branch from 8746df0 to c38f70e Compare January 19, 2022 22:33
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jan 20, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@rhmdnd: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test go-build
  • /test images
  • /test unit
  • /test verify

Use /test all to run all jobs.

In response to this:

/retest - timeout failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Jan 20, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm for the new changes

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@jhrozek
Copy link
Contributor

jhrozek commented Jan 25, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@jhrozek jhrozek merged commit 099b746 into openshift:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants