change setNodeEnv code to avoid warnings when using the Cloudflare adapter

[dario-piotrowicz]

This is a quick change to avoid warnings such as:

when using the Cloudflare adapter

I am not a huge fan of this change but, for a quick fix which doesn't require too much refactoring in the aws package, I think it's either this or patching the aws code on the Cloudflare adapter (as I've done in opennextjs/opennextjs-cloudflare#211).

(A more proper fix would be to make the aws code configurable so that when used by the Cloudflare adapter the setNodeEnv is either never called, thus three shaken away, or becomes a no-op function, but that as I referred to before would be a much bigger change, which might not be worth it right now)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 716436e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@686

commit: 716436e

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	23.25%	1761 / 7571
🔵	Statements	23.25%	1761 / 7571
🔵	Functions	56.83%	104 / 183
🔵	Branches	71.33%	448 / 628

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/open-next/src/adapters/util.ts	0%	100%	100%	0%	3-41

Generated in workflow #847 for commit 716436e by the Vitest Coverage Report Action

[conico974]

LGTM
Not a big fan of this change either to be honest. We need to find a better way of defining this (or delegate it to the platform itself).
Order of import can cause this issue #624

[dario-piotrowicz]

LGTM Not a big fan of this change either to be honest. We need to find a better way of defining this (or delegate it to the platform itself). Order of import can cause this issue #624

thanks 🙂

yeah I agree it does feel like this could be improved 😕