Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): bind waitUntil to ctx #635

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(cloudflare): bind waitUntil to ctx #635

merged 1 commit into from
Nov 19, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 19, 2024

Fix the error "TypeError: Illegal invocation: function called with incorrect this reference."

Fix the error "TypeError: Illegal invocation: function called with incorrect `this` reference."
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 4233456

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested a review from conico974 November 19, 2024 13:24
Copy link

pkg-pr-new bot commented Nov 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@635

commit: 4233456

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.42% 1657 / 7389
🔵 Statements 22.42% 1657 / 7389
🔵 Functions 56.32% 98 / 174
🔵 Branches 70.42% 412 / 585
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/overrides/wrappers/cloudflare.ts 0% 100% 100% 0% 6-66
Generated in workflow #756 for commit 4233456 by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb merged commit 9a5ef0a into main Nov 19, 2024
3 checks passed
@vicb vicb deleted the waitUntil branch November 19, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants