Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debug): never minify in debug mode #629

Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat(debug): never minify in debug mode #629

merged 1 commit into from
Nov 14, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 14, 2024

No description provided.

Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 47a3e11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.42% 1657 / 7389
🔵 Statements 22.42% 1657 / 7389
🔵 Functions 56.32% 98 / 174
🔵 Branches 70.42% 412 / 585
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/bundleNextServer.ts 0% 0% 0% 0% 1-108
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1-315
packages/open-next/src/build/edge/createEdgeBundle.ts 0% 0% 0% 0% 1-229
Generated in workflow #742 for commit 47a3e11 by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@629

commit: 47a3e11

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@@ -42,7 +42,11 @@ const externals = [
"next/dist/compiled/next-server",
];

export async function bundleNextServer(outputDir: string, appPath: string) {
export async function bundleNextServer(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this function should not be necessary in the future. Next should provide us directly with an already bundled NextServer in the future

@vicb vicb merged commit a6e0210 into main Nov 14, 2024
3 checks passed
@vicb vicb deleted the minify branch November 14, 2024 12:48
@vicb
Copy link
Contributor Author

vicb commented Nov 14, 2024

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants