Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update riscv-arch-test #808

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Update riscv-arch-test #808

merged 8 commits into from
Jun 20, 2024

Conversation

jordancarlin
Copy link
Member

@jordancarlin jordancarlin commented May 21, 2024

  • Update riscv-arch-test submodule and target dev branch
  • Remove Zfa wally-riscv-arch-test and replace with tests from riscv-arch-test
  • Update f_fma tests to use the new, smaller test files

Closes #783

@davidharrishmc
Copy link
Contributor

Jordan, the new riscv-arch-test repo had split the fma _b15 tests into several thousand tiny subfiles (~300 per instruction per precision). Our tests.vh only runs the -01 subfile, which is now 1/300th of the total set of tests.

https://github.com/riscv-non-isa/riscv-arch-test/tree/main/riscv-test-suite/rv32i_m/F/src

I've requested a smaller number of subfiles.

riscv-non-isa/riscv-arch-test#461 (comment)

I can't move to the new riscv-arch-test repo without doing something, or I'll lose all these fma tests. I've been waiting on this until they make a decision.

Thanks for preparing this PR. Let's hold off on accepting it until riscv-arch-test makes a decision.

@jordancarlin
Copy link
Member Author

Oh. I totally missed that. I saw that the issue preventing Zfa tests from working was resolved so figured I’d switch over, but let’s definitely wait on restructuring tests.vh until the fma tests settle.

@jordancarlin jordancarlin marked this pull request as draft May 21, 2024 16:52
@davidharrishmc
Copy link
Contributor

davidharrishmc commented Jun 11, 2024

fma looks like it has settled. There are now subdirectories in riscv-arch-test with the FMA tests split into 50 parts each, which is reasonable.

@jordancarlin do you have bandwidth to incorporate those fma tests into tests.vh as well, test it out, and update the PR with fma as well as Zfa?

@jordancarlin
Copy link
Member Author

jordancarlin commented Jun 11, 2024 via email

@davidharrishmc
Copy link
Contributor

davidharrishmc commented Jun 11, 2024 via email

@jordancarlin jordancarlin changed the title Use Zfa tests from riscv-arch-test instead of wally-riscv-arch-test Update riscv-arch-test Jun 19, 2024
@jordancarlin
Copy link
Member Author

jordancarlin commented Jun 19, 2024

@davidharrishmc Several of the b15 fma tests are currently commented out (some from F and D). Do we want to reenable them?

Only the b15 tests for F were split into smaller files, D and Zfh currently remain as they were.

@jordancarlin jordancarlin marked this pull request as ready for review June 20, 2024 14:49
@davidharrishmc davidharrishmc merged commit d8d94ee into openhwgroup:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use riscv-arch-test tests instead of wally-riscv-arch-test for Zfa
2 participants