-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update riscv-arch-test #808
Conversation
Jordan, the new riscv-arch-test repo had split the fma _b15 tests into several thousand tiny subfiles (~300 per instruction per precision). Our tests.vh only runs the -01 subfile, which is now 1/300th of the total set of tests. https://github.com/riscv-non-isa/riscv-arch-test/tree/main/riscv-test-suite/rv32i_m/F/src I've requested a smaller number of subfiles. riscv-non-isa/riscv-arch-test#461 (comment) I can't move to the new riscv-arch-test repo without doing something, or I'll lose all these fma tests. I've been waiting on this until they make a decision. Thanks for preparing this PR. Let's hold off on accepting it until riscv-arch-test makes a decision. |
Oh. I totally missed that. I saw that the issue preventing Zfa tests from working was resolved so figured I’d switch over, but let’s definitely wait on restructuring tests.vh until the fma tests settle. |
fma looks like it has settled. There are now subdirectories in riscv-arch-test with the FMA tests split into 50 parts each, which is reasonable. @jordancarlin do you have bandwidth to incorporate those fma tests into tests.vh as well, test it out, and update the PR with fma as well as Zfa? |
I saw that update a little while ago, but it looks like it’s just on the dev branch for now. Would we rather wait for the next release with these changes or switch our submodule to target the dev branch?
|
Good catch. Let’s wait. Feel free to ask Umer if there is a schedule to upstream this change.
… On Jun 11, 2024, at 7:31 AM, Jordan Carlin ***@***.***> wrote:
I saw that update a little while ago, but it looks like it’s just on the dev branch for now. Would we rather wait for the next release with these changes or switch our submodule to target the dev branch?On Jun 11, 2024, at 7:24 AM, David Harris ***@***.***> wrote:
fma looks like it has settled. There are now subdirectories in riscv-arch-test with the FMA tests split into 50 parts each, which is reasonable.
@jordancarlin do you have bandwidth to incorporate those fma tests into tests.vh as well, test it out, and update the PR with fma as well as Zfa?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub <#808 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR4AA36PQS3UMPV5XP3VJ33ZG4C5TAVCNFSM6AAAAABIBBVSU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQHEYTQOBZHE>.
You are receiving this because you commented.
|
@davidharrishmc Several of the b15 fma tests are currently commented out (some from F and D). Do we want to reenable them? Only the b15 tests for F were split into smaller files, D and Zfh currently remain as they were. |
Closes #783