Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofmt code updates #283

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Conversation

redhatrises
Copy link
Collaborator

ran gofmt on the code

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          32       32           
  Lines        1027     1027           
=======================================
  Hits          919      919           
  Misses         88       88           
  Partials       20       20
Impacted Files Coverage Δ
lib/opencontrol/versions/1.0.0/opencontrol.go 93.54% <0%> (ø) ⬆️
commands/get/resources/getter.go 91.26% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3353e...a2e62dd. Read the comment docs.

@redhatrises
Copy link
Collaborator Author

codecov patch report can be ignored as nothing as change except for formatting.
Ran gofmt on the code that codeclimate is reporting as a new issue... getting nothing. Looks bogus on codeclimate's part.

@shawndwells
Copy link
Member

@redhatrises clodeclimate shows one more gofmt error. Could that be addressed as well?

@redhatrises
Copy link
Collaborator Author

@shawndwells ran gofmt on the file that code climate is saying is the issue, and nothing is returned

@shawndwells
Copy link
Member

Hmm, yes, that appears odd after looking closer. The line throwing error:

https://github.com/opencontrol/compliance-masonry/blob/master/commands/get/resources/getter_test.go#L1

doesn't have formatting issues that are readily apparent, and wasn't touched by this PR, so merging.

@shawndwells shawndwells merged commit 3094a26 into opencontrol:master Jun 1, 2018
@redhatrises redhatrises deleted the gofmt_code branch June 1, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants