Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README for Storage-1.1: Storage File System Check #3686

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

AmrNJ
Copy link
Contributor

@AmrNJ AmrNJ commented Jan 8, 2025

The README is to verify the below storage OC paths.

/components/component/storage/state/counters
/components/component/storage/state/counters/soft-read-error-rate
/components/component/storage/state/counters/reallocated-sectors
/components/component/storage/state/counters/end-to-end-error
/components/component/storage/state/counters/offline-uncorrectable-sectors-count
/components/component/storage/state/counters/life-left
/components/component/storage/state/counters/percentage-used

@AmrNJ AmrNJ requested a review from a team as a code owner January 8, 2025 09:15
@OpenConfigBot
Copy link

OpenConfigBot commented Jan 8, 2025

Pull Request Functional Test Report for #3686 / 8bd8043

No tests identified for validation.

Help

@coveralls
Copy link

coveralls commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12716610834

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12714425637: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@rohit-rp rohit-rp self-assigned this Jan 8, 2025

## Procedure

* For each mountpoint collect and verify if the following path returns valid values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a definition of what "valid" means for each path. What is the logic that needs to be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added logic to verify the type of the data that is returned for each path.

@AmrNJ AmrNJ force-pushed the component-storage branch from fbfe9fe to 3f97528 Compare January 9, 2025 04:59
@dplore dplore changed the title Create README.md Create README for Storage-1.1: Storage File System Check Jan 10, 2025
@dplore dplore merged commit 407cbaf into openconfig:main Jan 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants