Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DP-2.4 test code #3654

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Add DP-2.4 test code #3654

wants to merge 31 commits into from

Conversation

vishnureddybadveli
Copy link
Contributor

Add DP-2.4 test code for police traffic on input interface matching all packets for ARISTA/CISCO.

@OpenConfigBot
Copy link

OpenConfigBot commented Dec 17, 2024 •
edited
Loading

Pull Request Functional Test Report for #3654 / 14687af

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Cisco 8000E status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Cisco XRd status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Juniper ncPTX status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Nokia SR Linux status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Openconfig Lemming status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Cisco 8808 status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Juniper PTX10008 status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Nokia 7250 IXR-10e status
 DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker

Help

@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12717582301

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%
Totals Coverage Status
Change from base Build 12716851483: 0.0%
Covered Lines: 1983
Relevant Lines: 3588
💛 - Coveralls

@sezhang2 sezhang2 self-assigned this Dec 18, 2024
@dplore
Copy link
Member

dplore commented Dec 26, 2024

/fptest virtual

@vishnureddybadveli vishnureddybadveli requested a review from a team as a code owner December 26, 2024 23:43
@sezhang2
Copy link
Contributor

Please resolve the conflict to fix the build error:

# github.com/openconfig/featureprofiles/internal/deviations
Error: internal/deviations/deviations.go:1270:34: lookupDUTDeviations(dut).GetGribiEncapHeaderUnsupported undefined (type *metadata_go_proto.Metadata_Deviations has no field or method GetGribiEncapHeaderUnsupported)

@vishnureddybadveli
Copy link
Contributor Author

Please resolve the conflict to fix the build error:

# github.com/openconfig/featureprofiles/internal/deviations Error: internal/deviations/deviations.go:1270:34: lookupDUTDeviations(dut).GetGribiEncapHeaderUnsupported undefined (type *metadata_go_proto.Metadata_Deviations has no field or method GetGribiEncapHeaderUnsupported)

Thank you, added missing file metadata.pb.go which resolved the error.

@vishnureddybadveli
Merge branch 'main' into vishnureddybadveli-patch-4
54dce58
@vishnureddybadveli
Update ingress_police_default_test.go with queue name "DEFAULT" inste…
3668cae 
…ad of "default"

Some how queue name is misinterpreted as network instance and check style is cribbing about it.
@vishnureddybadveli vishnureddybadveli requested a review from a team as a code owner January 3, 2025 02:18
@sezhang2
Copy link
Contributor

sezhang2 commented Jan 5, 2025

Please fix the failed check

_packets using 1 rate, 2 color marker
F0103 02:18:45.226004 3101 main.go:47] Problems found under feature root. Please make sure test paths follow feature/////test.go and all tests have an accompanying README.md in the test directory.
exit status 1
Error: Process completed with exit code 1.

@vishnureddybadveli
Copy link
Contributor Author

Please fix the failed check

_packets using 1 rate, 2 color marker F0103 02:18:45.226004 3101 main.go:47] Problems found under feature root. Please make sure test paths follow feature/////test.go and all tests have an accompanying README.md in the test directory. exit status 1 Error: Process completed with exit code 1.

Thank you,
Fixed formatting issue with README file.

sezhang2
sezhang2 previously approved these changes Jan 9, 2025
View reviewed changes
@vishnureddybadveli
Update ingress_police_default_test.go
cc90783 
Using QosSchedulerIngressPolicer deviation.
@vishnureddybadveli
Update metadata.textproto
658efe7 
Using QosSchedulerIngressPolicer deviation.
@vishnureddybadveli
Update deviations.go
1981997 
Using QosSchedulerIngressPolicer deviation.
@vishnureddybadveli
Update metadata.proto
e4f9584 
Using deviation QosSchedulerIngressPolicer
@vishnureddybadveli
Update metadata.pb.go
0d5b81b
@vishnureddybadveli
Merge branch 'main' into vishnureddybadveli-patch-4
14687af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezhang2 sezhang2 sezhang2 left review comments

@jaingaurav12 jaingaurav12 Awaiting requested review from jaingaurav12

@dplore dplore Awaiting requested review from dplore

Requested changes must be addressed to merge this pull request.

Assignees

@sezhang2 sezhang2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vishnureddybadveli @OpenConfigBot @coveralls @dplore @sezhang2