Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Req approvals #3634

Closed
wants to merge 3 commits into from
Closed

Req approvals #3634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a515611
added required approvals workflow
self-maurya Nov 6, 2024
354afa4
added comment
self-maurya Nov 7, 2024
e1dc2c9
apple
self-maurya Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# /feature folders each have owners who are auto requested for review and may merge PR's
/feature/acl/ @alokmtri-g
/feature/aft/ @sudhinj @yunjie-lu
/feature/bgp/ @dplore
/feature/bgp/ @dplore @rohit-rp
/feature/dhcp/ @alokmtri-g
/feature/ethernet/ @ram-mac
/feature/gribi/ @nflath @nachikethas @xw-g
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/required_approvals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# This workflow is to make sure we have 1 LGTM for business logic and 1 LGTM for code style
name: PR Approval Workflow
on:
pull_request:
branches:
- main
pull_request_review:
types: [submitted]

jobs:
check-approvals:
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
pull-requests: read
steps:
- name: Check for required approvals
id: check-approvals
uses: skymoore/required-approvals@main
with:
token: ${{ secrets.GITHUB_TOKEN }}
read_org_scoped_token: ${{ secrets.READ_ORG_SCOPED_TOKEN }}
org_name: openconfig
min_approvals: 2
approval_mode: ALL

1 change: 1 addition & 0 deletions feature/bgp/policybase/otg_tests/link_bandwidth_test/link_bandwidth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import (
)

const (
apple = "apple"
ipv4PrefixLen = 30
ipv6PrefixLen = 126
v41Route = "203.0.113.0"
Expand Down
Loading