RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria changes incorporated #3574

ampattan · 2024-11-11T18:35:59Z

Updated metadata.textproto

vender check included for NOKIA
Added deviations.

Updated import_export_multi_test.go

Added community-set-refs configuration for add_comm 60/70.
Delete routePolicy policy applied to neighbour before configurating multipolicy.
Added deviation for prefixset_Mode.
Policy result changed to ACCEPT from NEXT-STATEMENT for policy match_community_regex statements.

The policy "match_community_regex" contains a single, non-nested statement with a policy result "NEXT-STATEMENT," which is non-terminating. Therefore, the policy result has been updated to "ACCEPT_ROUTE," a definitive action.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

…eria Updated metadata.textproto -vender check included for NOKIA -Added deviations. Updated import_export_multi_test.go - Added community-set-refs configuration for add_comm 60/70. - Delete routePolicy policy applied to neighbour before configurating multipolicy. - Added deviation for prefixset_Mode. - Policy result changed to ACCEPT from NEXT-STATEMENT for policy match_community_regex statements. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

The policy "match_community_regex" contains a single, non-nested statement with a policy result "NEXT-STATEMENT," which is non-terminating. Therefore, the policy result has been updated to "ACCEPT_ROUTE," a definitive action. "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

OpenConfigBot · 2024-11-11T18:36:17Z

Pull Request Functional Test Report for #3574 / `0d3b213`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Cisco 8000E		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Cisco XRd		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Juniper ncPTX		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Nokia SR Linux		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Openconfig Lemming		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Cisco 8808		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Juniper PTX10008		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Nokia 7250 IXR-10e		RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria

Help

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

coveralls · 2024-11-15T23:02:03Z

Pull Request Test Coverage Report for Build 12696305394

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals
Change from base Build 12681294086:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

💛 - Coveralls

dplore · 2024-11-19T00:40:34Z

/fptest virtual

This reverts commit 108a1ff.

dplore · 2024-11-21T23:59:49Z

/fptest virtual

feature/bgp/policybase/otg_tests/import_export_multi_test/import_export_multi_test.go

dplore · 2024-11-22T01:23:23Z

Also, I see this fail on srlinux container. Here are the logs: https://gist.github.com/dplore/a225ebad5d96c00ea5adb9b9b885305f

On the next submission, please ensure at least that this passes on your platform.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

ampattan · 2024-12-02T19:04:54Z

HW log with these changes are available at - b/381853612

dplore · 2024-12-13T18:37:09Z

/fptest virtual

dplore · 2024-12-17T20:14:40Z

/fptest virtual

dplore

Just one suggestion left to use an await call instead of sleep for the traffic check.

feature/bgp/policybase/otg_tests/import_export_multi_test/import_export_multi_test.go

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

ampattan added 2 commits November 11, 2024 21:09

ampattan requested a review from dplore as a code owner November 11, 2024 18:35

MarcCharlebois assigned nsadhasivam Nov 11, 2024

MarcCharlebois added the nokia-pr label Nov 11, 2024

ampattan and others added 3 commits November 12, 2024 14:46

Merge branch 'main' into AP-rt7dot11

67afbb1

fixing interface level config and timer (openconfig#3577)

4f18c28

ampattan requested a review from rohit-rp as a code owner November 12, 2024 18:21

Merge branch 'main' into AP-rt7dot11

fac256c

dplore assigned dplore and unassigned nsadhasivam Nov 15, 2024

Merge branch 'main' into AP-rt7dot11

16a106d

dplore added the P1 Priority 1 label Nov 19, 2024

Revert "Removed "skip_bgp_send_community_type" deviation"

cee5956

This reverts commit 108a1ff.

dplore requested changes Nov 22, 2024

View reviewed changes

dplore removed the request for review from rohit-rp November 22, 2024 01:23

ampattan and others added 2 commits December 5, 2024 12:20

Merge branch 'main' into AP-rt7dot11

3b0458d

Merge branch 'main' into AP-rt7dot11

3f18155

Merge branch 'main' into AP-rt7dot11

ef1f61d

dplore requested changes Dec 27, 2024

View reviewed changes

Merge branch 'main' into AP-rt7dot11

f9d911e

ampattan requested a review from a team as a code owner January 8, 2025 11:50

dplore approved these changes Jan 10, 2025

View reviewed changes

dplore merged commit ba3bed8 into openconfig:main Jan 10, 2025
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria changes incorporated #3574

RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria changes incorporated #3574

ampattan commented Nov 11, 2024

OpenConfigBot commented Nov 11, 2024 •

edited

Loading

coveralls commented Nov 15, 2024 •

edited

Loading

dplore commented Nov 19, 2024

dplore commented Nov 21, 2024

dplore commented Nov 22, 2024

ampattan commented Dec 2, 2024

dplore commented Dec 13, 2024

dplore commented Dec 17, 2024

dplore left a comment

RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria changes incorporated #3574

RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria changes incorporated #3574

Conversation

ampattan commented Nov 11, 2024

OpenConfigBot commented Nov 11, 2024 • edited Loading

Pull Request Functional Test Report for #3574 / 0d3b213

Virtual Devices

Hardware Devices

coveralls commented Nov 15, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12696305394

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

dplore commented Nov 19, 2024

dplore commented Nov 21, 2024

dplore commented Nov 22, 2024

ampattan commented Dec 2, 2024

dplore commented Dec 13, 2024

dplore commented Dec 17, 2024

dplore left a comment

Choose a reason for hiding this comment

OpenConfigBot commented Nov 11, 2024 •

edited

Loading

Pull Request Functional Test Report for #3574 / `0d3b213`

coveralls commented Nov 15, 2024 •

edited

Loading