Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-1.32: BGP policy actions - MED LocPref changes incorporated #3447

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ampattan
Copy link
Contributor

@ampattan ampattan commented Sep 23, 2024

Updated metadata.textproto

  • ExplicitPortSpeed removed.

Updated actions_MED_LocPref_prepend_flow_control_test.go

  • The "deleteNbr" detail has been updated for RT-1.32.5 to address an issue where an unintended neighbor was being used for deleting the import and export policy.
  • The log messages have been modified to print proper value.
  • Skipping local-preference validation on eBGP based on RFC-4271, Section-5.1.5

The new yang changes for BGP MED policy action using updated ondatra

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Updated metadata.textproto
- ExplicitPortSpeed removed.

Updated actions_MED_LocPref_prepend_flow_control_test.go
- The check for `DefaultRoutePolicyUnsupported` in the Go code has been modified, leading to an unintended deviation that affects feature supported vendor.
- The log messages have been modified to print proper value.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@ampattan ampattan requested a review from dplore as a code owner September 23, 2024 10:55
@ampattan ampattan marked this pull request as draft November 15, 2024 17:06
- Restoring unrequired changes
- The "deleteNbr" detail has been updated for RT-1.32.5 to address an issue where an unintended neighbor was being used for deleting the import and export policy.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@dplore
Copy link
Member

dplore commented Nov 16, 2024

/fptest virtual

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11862757446

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11430798360: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@ampattan ampattan marked this pull request as ready for review November 16, 2024 07:31
@ampattan ampattan removed their assignment Nov 16, 2024
@ampattan ampattan marked this pull request as draft November 23, 2024 07:46
  - Removed local-preference validation on eBGP.
  - Added "set-med-action" as per new yang model.

- Added updated ondatra files.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants