-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lifecycle statuses to all documents #1385
Conversation
Please rebase and checks will run |
82df17d
to
d6814a6
Compare
@bogdandrutu resolved |
I know that environment variables are deemed optional in the spec matrix but some languages have already implemented some of them. In this case, will the env var names be marked as "stable" here as well or will there possible breaking changes in the future (such as the recent OTEL_EXPORTERS -> OTEL_METRICS_EXPORTER + OTEL_TRACE_EXPORTER)? We need to know whether or not we can release env var functionality as part of 1.0.0. |
I'd be nice if we could lock down the semantics folks were already relying on here without having to fully lock down everything about environment variables. The OTEL_EXPORTERS change was one where we likely WILL be doing deprecation + migration in the future, and we could have done that here for existing SDKs rather than force migrate prior to 1.0.0. It'd be nice if we agreed to "1.0" environment variables (even if they're optional, we still won't change semantics in breaking ways). so +1 to answering this question. |
@lzchen @jsuereth I think there are two questions about env vars.
Since they are currently experimental, I would like to mark them here as such. A separate issue can then be opened to address making them stable. Does that sound good to you two? |
@tedsuo |
specification/protocol/otlp.md
Outdated
@@ -1,5 +1,7 @@ | |||
# OpenTelemetry Protocol Specification | |||
|
|||
**Status**: [Stable](../document-status.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is are discussion in this document about JSON being supported for OTLP/HTTP which I think we are not yet ready to make it stable. How can we solve that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I marked OTLP/HTTP as experimental. The JSON and binary formats for HTTP were intermixed; if we want proto over OTLP/HTTP to be stable this section should be re-written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OTLP/HTTP-Protobufs are stable. Only OTLP/HTTP-JSON is unstable. Please file a TODO to fix this.
We should probably also note that only Traces are currently stable. Looks like we are going to end up with a lot of clarifications for our stability declarations in this file to be true, but that's the reality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tigrannajaryan. I created a follow up issue: #1397
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bogdandrutu Please review. I think that we are ready to merge this and tune the OTLP/JSON part in the related follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, we need to update the status of the doc again or is it still in experimental? |
Changes
Related issues #