Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain why structured Body is valuable in log data model #2066

Closed
tigrannajaryan opened this issue Oct 27, 2021 · 2 comments · Fixed by #2096
Closed

Explain why structured Body is valuable in log data model #2066

tigrannajaryan opened this issue Oct 27, 2021 · 2 comments · Fixed by #2096
Assignees
@carlosalberto
Labels
release:required-logdatamodel-ga Required for declaring log data model stable spec:logs Related to the specification/logs directory

Comments

@tigrannajaryan
Copy link
Member

We think that there is value in allowing Body to be structured in the data model, particularly for the purpose of representing non-OpenTelemetry data formats unambiguously. We need to explain this value in the data model document.
@tigrannajaryan tigrannajaryan added the spec:logs Related to the specification/logs directory label Oct 27, 2021
@tigrannajaryan tigrannajaryan mentioned this issue Oct 27, 2021
Closed
@jmacd
Copy link
Contributor

jmacd commented Oct 28, 2021

Other ideas for structure.
To avoid ambiguity for number values, e.g., is the string "10" a hexadecimal 16 or decimal 10?
To log a representation of cyclic data structures.
To refer to entities by logging a structured identifying key.

@tigrannajaryan
Copy link
Member Author

tigrannajaryan commented Oct 29, 2021 •
edited
Loading

To refer to entities by logging a structured identifying key.

Which I think is partially captured in #579 but blocked by #376 with lots of objections about allowing non-primitive values for attributes.

@djaglowski djaglowski mentioned this issue Nov 2, 2021
Merged
@tigrannajaryan tigrannajaryan added the release:required-logdatamodel-ga Required for declaring log data model stable label Nov 4, 2021
tigrannajaryan pushed a commit that referenced this issue Nov 4, 2021
@djaglowski
Explain expected usage of log body (#2096)
32d6965 
Resolves #2066 and #1752

Supports #2068

## Changes

Adds a note to the log data model which explains the intended usage of the `Body` field. 

## Additional Context

Extensive discussion has been had on this issue on [#1613](#1613 (comment)), as well as in the Log SIG group.
@djaglowski djaglowski mentioned this issue Mar 8, 2024
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@djaglowski
Explain expected usage of log body (open-telemetry#2096)
f6af53c 
Resolves open-telemetry#2066 and open-telemetry#1752

Supports open-telemetry#2068

## Changes

Adds a note to the log data model which explains the intended usage of the `Body` field. 

## Additional Context

Extensive discussion has been had on this issue on [open-telemetry#1613](open-telemetry#1613 (comment)), as well as in the Log SIG group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosalberto carlosalberto

Labels
release:required-logdatamodel-ga Required for declaring log data model stable spec:logs Related to the specification/logs directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explain expected usage of log body observIQ/opentelemetry-specification
3 participants
@carlosalberto @jmacd @tigrannajaryan