Polish document content in README.md #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
suggested changes
Apr 3, 2024
There was a problem hiding this comment.
This is not a typo. oneof is a protobuf field type.
https://protobuf.dev/programming-guides/proto3/#oneof
Sorry, I am not familiar with it very much before：）Is it better to add `` to relevant protobuf keyword to distinguish with normal English word? |
steverao
changed the title
Fix wrong spelling in README.md
arminru
approved these changes
Apr 9, 2024
yurishkuro
approved these changes
Apr 9, 2024
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
* Fix wrong spelling in README.md Fix wrong spelling in README.md * Polish document content
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
* Fix wrong spelling in README.md Fix wrong spelling in README.md * Polish document content
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
* Fix wrong spelling in README.md Fix wrong spelling in README.md * Polish document content
VinozzZ
pushed a commit
to VinozzZ/opentelemetry-proto
that referenced
this pull request
Jun 21, 2024
* Fix wrong spelling in README.md Fix wrong spelling in README.md * Polish document content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polish document content in README.md