Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documented scope return values #1025

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jun 6, 2023

TC review suggests that DETACHED and INACTIVE responses need clarification

Fixes #1018

TC review suggests that DETACHED and INACTIVE responses need clarification
@brettmc brettmc requested a review from a team June 6, 2023 02:45
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1025 (55eea29) into main (1b63a3b) will not change coverage.
The diff coverage is n/a.

❗ Current head 55eea29 differs from pull request most recent head a5966d5. Consider uploading reports for the commit a5966d5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1025   +/-   ##
=========================================
  Coverage     81.74%   81.74%           
  Complexity     2155     2155           
=========================================
  Files           276      276           
  Lines          6146     6146           
=========================================
  Hits           5024     5024           
  Misses         1122     1122           
Flag Coverage Δ
7.4 80.37% <ø> (ø)
8.0 81.68% <ø> (ø)
8.1 81.88% <ø> (ø)
8.2 81.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Context/Context.php 80.95% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b63a3b...a5966d5. Read the comment docs.

@pdelewski pdelewski merged commit 6a77cf5 into open-telemetry:main Jun 7, 2023
@brettmc brettmc deleted the clarify-scope-return-values branch July 17, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TC Review] Clarify DETACHED and INACTIVE in ScopeInterface
2 participants