Update develocity config #12835
Merged
Update develocity config #12835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Dec 6, 2024
| @@ -366,13 +366,6 @@ tasks.withType<Test>().configureEach { | |||
| // This value is quite big because with lower values (3 mins) we were experiencing large number of false positives | |||
| timeout.set(Duration.ofMinutes(15)) | |||
|
|
|||
| develocity.testRetry { | |||
There was a problem hiding this comment.
I guess this will force us to deal with the flaky tests. Can always add it back if there are too many build failures.
There was a problem hiding this comment.
yeah, I was worried about us never seeing flaky tests if we don't remove it, but I realized a better option is probably to only disable retries on the daily builds in order to not disrupt other workflows (PRs / releases), will update this PR
There was a problem hiding this comment.
I updated this PR, can you give it one more look now? thanks
laurit
approved these changes
Dec 6, 2024
laurit
approved these changes
Dec 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😢
TODO delete
GRADLE_ENTERPRISE_ACCESS_KEYgithub action secret after merging this