Add an option to disable automatic kafka interceptor configuration in spring starter #12833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
zeitlinger
approved these changes
Dec 5, 2024
trask
approved these changes
Dec 7, 2024
|
Thanks, appreciate your effort on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11793
Based on #11793 (comment) by @zeitlinger Add an option to disable automatic configuration of interceptors and exposes
SpringKafkaTelemetryas bean so that user could get access to the interceptors and manually add the interceptors. Also try to read the existing interceptors fromConcurrentKafkaListenerContainerFactoryand wrap them instead of overwriting. Note that similarly to how we could end up overwriting user configured interceptors the user can also overwrite our interceptors.