Improve whitespace handling in oracle jdbc url parser #12512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
jaydeluca
approved these changes
Oct 24, 2024
steverao
reviewed
Oct 24, 2024
| @@ -530,10 +530,12 @@ DbInfo.Builder doParse(String jdbcUrl, DbInfo.Builder builder) { | |||
| }, | |||
|
|
|||
| ORACLE_AT() { | |||
| private final Pattern descriptionPattern = Pattern.compile("@\\s*\\(\\s*description"); | |||
There was a problem hiding this comment.
For constant, use capital here?
There was a problem hiding this comment.
as far as I know our coding rules do not allow using upper case for non static fields
There was a problem hiding this comment.
I think @laurit's correct: https://google.github.io/styleguide/javaguide.html#s5.2.4-constant-names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12400