-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline incubating semconv attributes #1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I must have missed something in the comment...why is it desirable to copy/duplicate these constants?
|
So the entire purpose here is to avoid taking a dependency on an artifact with Maybe we figure that the tests (which use the |
we're worried about diamond dependency problem where some users will end up depending (transitively) on different irreconcilable versions of the semconv alpha artifact
yeah, though it would be interesting to validate this |
The guidance given in https://github.com/open-telemetry/semantic-conventions-java/blob/main/README.md states that
|
@breedx-splk I'm going to merge since this is the (current) convention in this repo, but we can revisit |
Follow-up to @laurit's #1585 (comment)