Checkpoint only after Update; Keep records in the sync.Map longer #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes TODOs left from #468. An atomic increment is carried out for each
Update()
, allowing the collection logic to checkpoint records only when they have actually received updates (2 TODOs). This was mentioned in the review for #641.This allows an optimization that had been in place before #468, that is to defer unmapping a record until it has survived a whole collection interval without being updated (1 TODO). This ensures that users of the direct calling convention that happen to repeatedly use the same label set will benefit from cached label encodings.
BEFORE:
AFTER: