Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are trying to send span to Zipkin without localEndpoint or with serviceName equals to empty string (as opentelemetry-go Zipkin exporter does), Zipkin UI is failing with error, while rendering traces with such error:
To fix this, I add mandatory serviceName parameter to
NewExporter
function.Also add assert if
serviceName == ""
+ test for it and fix the example.