Update OTLP SpanData transform #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ParentSpanId needs to be empty for root spans according to the OTLP [docs](https://github.com/open-telemetry/opentelemetry-proto/blob/6c2a86ed2f74ca46f979f22c77f0aad449fb9629/gen/go/trace/v1/trace.pb.go#L284-L286). This updates the SpanData transform function to not add the ParentSpanID if it is not a valid span ID (which includes if it is the nil span ID used for an unset ID). Additionally, this adds a test to prevent regression.
MrAlias
requested review from
jmacd,
krnowak,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
rghetia
reviewed
Apr 3, 2020
rghetia
approved these changes
Apr 6, 2020
krnowak
approved these changes
Apr 7, 2020
|
Not sure why that test failed. It doesn't look related to this PR AFAIK. Going to close and reopen to kick off another build. |
jmacd
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ParentSpanIdneeds to be empty for root spans according to the OTLP docs. This updates the SpanData transform function to not add theParentSpanIDif it is not a valid span ID (which includes if it is the nil span ID used for an unset ID).Additionally, this adds a test to prevent regression.