Make span start/end configuration more greppable #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename SpanOption to StartOption Rename StartOptions to StartConfig Rename EndOptions to EndConfig fixes open-telemetry#197
ferhatelmas
requested review from
iredelmeier,
jmacd,
lizthegrey,
paivagustavo,
rghetia,
sjkaris and
tedsuo
as code owners
rghetia
reviewed
Dec 4, 2019
lizthegrey
approved these changes
Dec 4, 2019
rghetia
reviewed
Dec 4, 2019
rghetia
approved these changes
Dec 4, 2019
jmacd
approved these changes
Dec 4, 2019
|
3 approvals, including from a maintainer, going to squash this as soon as tests pass. |
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
…3 Propagator. (#369) According to the spec. Debug sampling decision implies accept(sampled) decision. But we didn't set sample bitmask. So when trace state is debug, `IsSampled` method will still return false, which is different from spec. Now we make sure when debug bitmask is set, sample bitmask will also be set. Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
to improve the distinction between start and end.
Config suffix extends vocabulary to improve grepping and usable variable names.
fixes #197