Use a formula for tolerance in sampling tests #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
bogdandrutu,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
|
The tolerances shift from 0.015 to around 0.02 (the 25% and 75% tests) and around 0.024 (the 50% test). |
lizthegrey
approved these changes
Nov 8, 2019
krnowak
approved these changes
Nov 8, 2019
|
|
||
| if tc.expect > 0 && tc.expect < 1 { | ||
| // See https://en.wikipedia.org/wiki/Binomial_proportion_confidence_interval | ||
| const z = 4.75342 // This should succeed 99.9999% of the time |
There was a problem hiding this comment.
I'd prefer if you went with the Wilson score interval with continuity correction.
Joking, of course. ;)
rghetia
approved these changes
Nov 8, 2019
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
…#298) * fix: change options to accept providers * fix: include semver in instrumentation creation * fix: lint * fix: Change WithTraceProvider to WithTracerProvider Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a formula and relaxes the tolerance to fail less often.
Here was a flake:
https://circleci.com/gh/open-telemetry/opentelemetry-go/782?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link