Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-1.17-compatible build directives #2263

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

evantorrie
Copy link
Contributor

@evantorrie evantorrie commented Sep 27, 2021

go-1.17 adds a new go build constraint format for inclusion at the head of *.go files. This PR adds the new go-1.17 compatible build constraint format, while keeping the pre go-1.17 format for compatibility.

The reason for this PR is to avoid make precommit with a go-1.17 compiler/linting toolset from wanting to modify these files every time it's run.

@evantorrie evantorrie added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #2263 (348d7b4) into main (28f335e) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2263   +/-   ##
=====================================
  Coverage   72.4%   72.5%           
=====================================
  Files        168     168           
  Lines      11872   11872           
=====================================
+ Hits        8606    8616   +10     
+ Misses      3031    3024    -7     
+ Partials     235     232    -3     
Impacted Files Coverage Δ
sdk/resource/os_unix.go 75.0% <ø> (ø)
sdk/metric/sdk.go 81.6% <0.0%> (+1.4%) ⬆️
...s/otlp/otlptrace/internal/connection/connection.go 16.4% <0.0%> (+1.5%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+20.0%) ⬆️

@pellared
Copy link
Member

You can do the same for other GOOSes 😉

@MrAlias MrAlias merged commit 00d8ca5 into open-telemetry:main Sep 28, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants