Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testCollectorEndpoint typo and add tag assertions in jaeger_test #1751

Closed

Conversation

IrisTuntun
Copy link
Contributor

  1. Fixed the typo testCollectorEnpoint to testCollectorEndpoint.
  2. Added assertions on process tags in gen.Batch that was exported in TestNewExporterPipelineWithOptions.

Fixes #1699
Note: gen.Batch has already been recorded in testCollectorEndpoint thanks to #1693

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 29, 2021

CLA Missing ID

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #1751 (c004d06) into main (604b05c) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1751     +/-   ##
=======================================
- Coverage   78.0%   78.0%   -0.1%     
=======================================
  Files        132     132             
  Lines       6941    6941             
=======================================
- Hits        5417    5415      -2     
- Misses      1274    1276      +2     
  Partials     250     250             
Impacted Files Coverage Δ
exporters/otlp/otlpgrpc/connection.go 86.9% <0.0%> (-1.9%) ⬇️

@IrisTuntun IrisTuntun closed this Mar 29, 2021
@IrisTuntun
Copy link
Contributor Author

Close this PR since the commit was not pushed with the correct user id. Will open a new one later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test exporting a batch of spans from Jaeger Exporter is working as expected
1 participant