Span status from HTTP code: Do not set status message if it can be inferred #1681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant specification section:
The rationale
Although method
SpanStatusFromHTTPStatusCode
is not directly responsible for setting the span status code and message, many instrumentation packages depend directly on it to set the span status. This puts the burden of setting the appropriate span message on those instrumentation packages.The change presented in this PR ensures that method
SpanStatusFromHTTPStatusCode
returns span status code and message which can be directly used and would adhere to the requirements, i.e. for error statuses where the reason can be inferred fromhttp.status_code
attribute, the span status message will be unset (empty).Resolves (partially) #1376