Fix the examples target info messaging #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The echo for the target was copied from other targets that use `dir` as an iteration variable which is not what this target uses. That means that the empty variable `dir` is unexpanded and the unhelpful message of "build /..." is echoed. This updates the iteration variable to match other targets and fixes the info messaging.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1676 +/- ##
=====================================
Coverage 77.1% 77.1%
=====================================
Files 128 128
Lines 6735 6735
=====================================
+ Hits 5196 5198 +2
+ Misses 1288 1286 -2
Partials 251 251
|
Aneurysm9
approved these changes
Mar 8, 2021
|
Going to merge as this is a small bug fix in the build tooling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The echo for the target was copied from other targets that use
diras an iteration variable which is not what this target uses. That means that the empty variablediris unexpanded and the unhelpful message of "build /..." is echoed. This updates the iteration variable to match other targets and fixes the info messaging.Verified locally: