Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP/JSON to the otlp exporter #1586

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

MadVikingGod
Copy link
Contributor

This is the 3rd and final otlp format the spec specifies. We currently already implement grpc and HTTP/protobuf.

Usage

A new option is available for the otlphttp exporter. Configuration using WithMarshal(MarshalJSON) will result in the HTTP request using json.

This would close #1122

Co-Authored-By: Roy van de Water <[email protected]>
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1586 (bc95789) into main (62e2a0f) will increase coverage by 0.0%.
The diff coverage is 92.3%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1586   +/-   ##
=====================================
  Coverage   77.3%   77.3%           
=====================================
  Files        128     128           
  Lines       6671    6681   +10     
=====================================
+ Hits        5157    5168   +11     
+ Misses      1267    1266    -1     
  Partials     247     247           
Impacted Files Coverage Δ
exporters/otlp/otlphttp/options.go 66.6% <66.6%> (ø)
exporters/otlp/otlphttp/driver.go 93.8% <100.0%> (+0.3%) ⬆️
exporters/otlp/otlpgrpc/connection.go 88.7% <0.0%> (+1.8%) ⬆️

@XSAM XSAM self-requested a review March 3, 2021 14:03
exporters/otlp/otlphttp/driver.go Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the RC1 milestone Mar 4, 2021
@MrAlias MrAlias merged commit 7153ef2 into open-telemetry:main Mar 5, 2021
@MrAlias MrAlias mentioned this pull request Mar 18, 2021
@MadVikingGod MadVikingGod deleted the OTLP-HTTP-json branch August 11, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP protocol support to OTLP
4 participants