Fix Code.UnmarshalJSON to work with valid json only
#1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstdfx
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
========================================
- Coverage 76.8% 76.8% -0.1%
========================================
Files 122 122
Lines 5944 5953 +9
========================================
+ Hits 4568 4574 +6
- Misses 1129 1131 +2
- Partials 247 248 +1
|
dstdfx
changed the title
MrAlias
approved these changes
Oct 26, 2020
XSAM
approved these changes
Oct 27, 2020
jmacd
reviewed
Oct 27, 2020
Signed-off-by: Daniil Rutskiy <[email protected]>
Signed-off-by: Daniil Rutskiy <[email protected]>
dstdfx
force-pushed
the
fix/codes-marshal-unmarshal
branch
from
6e5c86f to
bc761ab
Compare
Signed-off-by: Daniil Rutskiy <[email protected]>
dstdfx
changed the title
Code.UnmarshalJSON to work with valid json only
Signed-off-by: Daniil Rutskiy <[email protected]>
Signed-off-by: Daniil Rutskiy <[email protected]>
dstdfx
force-pushed
the
fix/codes-marshal-unmarshal
branch
from
c4109e1 to
bca44b6
Compare
jmacd
approved these changes
Oct 27, 2020
MrAlias
approved these changes
Oct 27, 2020
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
…#1276) * Remove quotes from UnmarshalJSON Signed-off-by: Daniil Rutskiy <[email protected]> * Update CHANGELOG.md Signed-off-by: Daniil Rutskiy <[email protected]> * Fix issue number in CHANGELOG.md * Fix 'Code.UnmarshalJSON' to work with valid json only Signed-off-by: Daniil Rutskiy <[email protected]> * Extend test data for TestCodeUnmarshalJSONErrorInvalidData Signed-off-by: Daniil Rutskiy <[email protected]> * Delete useless cond, extend test data Signed-off-by: Daniil Rutskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1273