Add a Shutdown method to sdk TraceProvider #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huikang
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1227 +/- ##
========================================
- Coverage 76.9% 76.8% -0.1%
========================================
Files 122 122
Lines 5927 5931 +4
========================================
- Hits 4559 4558 -1
- Misses 1121 1126 +5
Partials 247 247
|
Aneurysm9
reviewed
Oct 7, 2020
huikang
force-pushed
the
1206-shutdown-processor
branch
from
87744c8 to
b890dec
Compare
MrAlias
added
area:trace
MrAlias
requested changes
Oct 8, 2020
There was a problem hiding this comment.
I think we can scope this to just the SDK for now and get this merged. Otherwise, we should probably wait for resolution on open-telemetry/opentelemetry-specification#1073
MrAlias
added
the
blocked:specification
XSAM
removed
the
blocked:specification
huikang
force-pushed
the
1206-shutdown-processor
branch
2 times, most recently
from
886cf2e to
c5470d0
Compare
- sdktraceprovider shutdown span processors - In examples, replace processosr shutdown with traceprovider's shutdown Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
1206-shutdown-processor
branch
3 times, most recently
from
ba3d6d7 to
bf736b5
Compare
huikang
changed the title
huikang
force-pushed
the
1206-shutdown-processor
branch
from
bf736b5 to
5900051
Compare
huikang
force-pushed
the
1206-shutdown-processor
branch
from
2c12fd8 to
332e2ea
Compare
Aneurysm9
approved these changes
Oct 21, 2020
XSAM
approved these changes
Oct 22, 2020
MrAlias
approved these changes
Oct 26, 2020
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Add a Shutdown method to api TraceProvider - sdktraceprovider shutdown span processors - In examples, replace processosr shutdown with traceprovider's shutdown Signed-off-by: Hui Kang <[email protected]> * remove shutdown in the api provider interface * Add context in parameter and return error * handle error in shutdown * Update CHANGELOG.md Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traceprovider's shutdown
Resolves #1206
Signed-off-by: Hui Kang [email protected]