Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK ignores "FollowsFrom" relationships #189

Closed
iredelmeier opened this issue Oct 10, 2019 · 2 comments · Fixed by #190
Closed

SDK ignores "FollowsFrom" relationships #189

iredelmeier opened this issue Oct 10, 2019 · 2 comments · Fixed by #190
Milestone
untracked

Comments

@iredelmeier
Copy link
Member

Currently, the SDK only propagates the parent through the context or if the provided reference is explicitly set to ChildOfRelationshipType. FollowsFromRelationshipType parents thus get ignored, which seems unexpected.
@iredelmeier
Copy link
Member Author

CC @rghetia since you left what looks like a relevant TODO.

iredelmeier referenced this issue in iredelmeier/opentelemetry-go Oct 10, 2019
@iredelmeier
Propagate FollowsFrom span relationships in SDK
1c96105 
[Closes #189]
@iredelmeier iredelmeier mentioned this issue Oct 10, 2019
Merged
iredelmeier referenced this issue in iredelmeier/opentelemetry-go Oct 11, 2019
@iredelmeier
Propagate FollowsFrom span relationships in SDK
486bb9b 
[Closes #189]
@iredelmeier iredelmeier mentioned this issue Oct 11, 2019
Merged
@iredelmeier
Copy link
Member Author

This becomes unnecessary if we instead go with #193.

rghetia pushed a commit that referenced this issue Oct 14, 2019
@iredelmeier @rghetia
Propagate FollowsFrom span relationships in SDK (#190)
849cdc7 
[Closes #189]
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@MrAlias
Move gRPC instrumentation from go.opentelemetry.io/otel (#189)
87806b1 
* Add google.golang.org/grpc instrumentation from otel repo

Move the existing grpctrace package from the go.opentelemetry.io/otel
repository to here. This is based on the package last modified in:
96a5f8f

This is related to:
https://github.com/open-telemetry/opentelemetry-go/issues/976

* Update package name: grpctrace -> grpc

* Revert back to the v0.10.0 api/standard package for now

* Make into Go module

* Update the Changelog

* Move the gRPC example from otel

Taken from the otel repository at
5438916

* Update packaging of example

* Update go.sum for example

* Add grpc instrumentation to dependabot config
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Propagate FollowsFrom span relationships in SDK iredelmeier/opentelemetry-go
2 participants
@iredelmeier @pellared