Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosslink: Add work command #311

Merged
merged 22 commits into from
May 18, 2023
Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented May 15, 2023

Why

Fixes #309

Towards open-telemetry/opentelemetry-go#3964

go.work is honored by gopls language server so that develoeprs get better UX in tools like VSCode, Vim, Emacs etc

References:

Prior work: #308

What

Make crosslink to create/update the use in go.work file (if it exists).

Take notice that it will not harm any repositories which do not use Go workspaces. However developers could still use the functionality during development 😉

Testing

make gowork

created following go.work file

go 1.19

use (
	./checkdoc
	./chloggen
	./crosslink
	./dbotconf
	./
	./gotmpl
	./internal/tools
	./issuegenerator
	./multimod
	./semconvgen
)

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 72.18% and project coverage change: +0.94 🎉

Comparison is base (6d04deb) 58.99% compared to head (ed6ce24) 59.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   58.99%   59.93%   +0.94%     
==========================================
  Files          46       47       +1     
  Lines        2024     2134     +110     
==========================================
+ Hits         1194     1279      +85     
- Misses        698      715      +17     
- Partials      132      140       +8     
Impacted Files Coverage Δ
crosslink/internal/config.go 81.25% <ø> (ø)
crosslink/internal/common.go 55.88% <50.00%> (-3.21%) ⬇️
crosslink/internal/graph.go 81.96% <54.54%> (+8.05%) ⬆️
crosslink/internal/work.go 75.78% <75.78%> (ø)
crosslink/cmd/root.go 73.33% <80.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pellared pellared marked this pull request as ready for review May 15, 2023 12:30
@pellared pellared requested review from a team and codeboten May 15, 2023 12:30
@pellared pellared changed the title [WIP] crosslink: Add work command crosslink: Add work command May 15, 2023
@pellared pellared requested a review from bryan-aguilar May 15, 2023 12:31
crosslink/README.md Outdated Show resolved Hide resolved
crosslink/cmd/root.go Outdated Show resolved Hide resolved
crosslink/cmd/root.go Show resolved Hide resolved
crosslink/internal/work.go Outdated Show resolved Hide resolved
crosslink/README.md Outdated Show resolved Hide resolved
crosslink/internal/common.go Show resolved Hide resolved
@pellared pellared requested a review from mx-psi May 16, 2023 14:39
crosslink/internal/work_test.go Outdated Show resolved Hide resolved
crosslink/README.md Show resolved Hide resolved
crosslink/cmd/root.go Outdated Show resolved Hide resolved
@pellared pellared requested a review from bryan-aguilar May 18, 2023 12:36
@MrAlias MrAlias merged commit a570d1a into open-telemetry:main May 18, 2023
@pellared pellared deleted the crosslink-work branch May 18, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crosslink: Add support for go.work files
5 participants