-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crosslink: Add work command #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 58.99% 59.93% +0.94%
==========================================
Files 46 47 +1
Lines 2024 2134 +110
==========================================
+ Hits 1194 1279 +85
- Misses 698 715 +17
- Partials 132 140 +8
☔ View full report in Codecov by Sentry. |
pellared
changed the title
[WIP] crosslink: Add work command
crosslink: Add work command
May 15, 2023
hanyuancheung
approved these changes
May 15, 2023
mx-psi
reviewed
May 15, 2023
MrAlias
reviewed
May 15, 2023
Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
mx-psi
reviewed
May 16, 2023
MrAlias
approved these changes
May 16, 2023
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
approved these changes
May 16, 2023
Co-authored-by: bryan-aguilar <[email protected]>
bryan-aguilar
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #309
Towards open-telemetry/opentelemetry-go#3964
go.work
is honored bygopls
language server so that develoeprs get better UX in tools like VSCode, Vim, Emacs etcReferences:
Prior work: #308
What
Make
crosslink
to create/update theuse
ingo.work
file (if it exists).Take notice that it will not harm any repositories which do not use Go workspaces. However developers could still use the functionality during development 😉
Testing
created following
go.work
file