Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] - sort currency list #448

Merged
merged 2 commits into from
Oct 14, 2022
Merged

[frontend] - sort currency list #448

merged 2 commits into from
Oct 14, 2022

Conversation

puckpuck
Copy link
Contributor

Changes

Sorts the list of currencies in the currency selector.
Screen Shot 2022-10-14 at 2 34 20 PM

@puckpuck puckpuck requested a review from a team October 14, 2022 18:34
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@mic-max mic-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice change, 1 comment about implementation detail

src/frontend/providers/Currency.provider.tsx Outdated Show resolved Hide resolved
@cartersocha cartersocha merged commit 96d0611 into open-telemetry:main Oct 14, 2022
@puckpuck puckpuck deleted the frontend.sort-currency branch October 17, 2022 22:15
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* sort currency list

* sort currency list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants