Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[featureflag] otel exporter dependency first #445

Merged
merged 3 commits into from
Oct 14, 2022
Merged

[featureflag] otel exporter dependency first #445

merged 3 commits into from
Oct 14, 2022

Conversation

puckpuck
Copy link
Contributor

Fixes

Prevents this warning message from appearing in the FeatureFlag service logs

[warning] OTLP exporter failed to initialize with exception :throw:{:application_either_not_started_or_not_ready, :tls_certificate_check}

Changes

Moves the OTLP exporter dependency to before other otel dependencies. Following instructions from the Erlang repo here

@puckpuck puckpuck requested a review from a team October 14, 2022 05:47
julianocosta89
julianocosta89 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuilt and tested locally, LGTM!

@cartersocha cartersocha merged commit 6ccb66d into open-telemetry:main Oct 14, 2022
@puckpuck puckpuck deleted the ffs.exporter-dependency branch October 14, 2022 06:16
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck
otel exporter dependency first (open-telemetry#445)
0b20b37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puckpuck @julianocosta89 @cartersocha