[frontend] fix local development instructions and dependencies #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mic-max
approved these changes
Oct 12, 2022
The frontend loads and works fine, but if you want to test all views, the checkout process fails, because checkout calls shippingservice that calls quoteservice. |
xoscar
approved these changes
Oct 13, 2022
austinlparker
approved these changes
Oct 13, 2022
reyang
approved these changes
Oct 13, 2022
chancez
pushed a commit
to chancez/opentelemetry-demo
that referenced
this pull request
Oct 13, 2022
Signed-off-by: Chance Zibolski <[email protected]>
puckpuck
added a commit
that referenced
this pull request
Oct 18, 2022
Signed-off-by: Chance Zibolski <[email protected]> Signed-off-by: Chance Zibolski <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…y#439) Signed-off-by: Chance Zibolski <[email protected]> Signed-off-by: Chance Zibolski <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #407 .
Changes
When moving from
CMDtoENTRYPOINTwe forgot to update the instructions for the frontend local development.Also, the
quoteservicewas added as a dependency offrontendto avoid errors during local development.