Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit updates #427

Merged
merged 3 commits into from
Oct 11, 2022
Merged

nit updates #427

merged 3 commits into from
Oct 11, 2022

Conversation

cartersocha
Copy link
Contributor

Small doc clean up

@cartersocha cartersocha requested a review from a team October 11, 2022 04:07
mviitane
mviitane approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

julianocosta89
julianocosta89 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment but not a blocker, we can also do that in a new PR.

docs/service_table.md Show resolved Hide resolved
@cartersocha cartersocha merged commit 1fdc027 into open-telemetry:main Oct 11, 2022
@cartersocha cartersocha deleted the nits branch October 14, 2022 19:23
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@cartersocha
nit updates (open-telemetry#427)
d26ecd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mviitane mviitane mviitane approved these changes

@reyang reyang reyang approved these changes

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cartersocha @puckpuck @fatsheep9146 @julianocosta89 @reyang @mviitane