Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recommendation logic not to recommend the selected product #417

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Fix recommendation logic not to recommend the selected product #417

merged 2 commits into from
Oct 8, 2022

Conversation

mviitane
Copy link
Member

@mviitane mviitane commented Oct 8, 2022

Changes

  • There was a fault in the recommendation logic that it offered also the same products which the user just opened (product page) or added to the cart (shopping cart page). The filtering logic not to recommend the same products was fixed.
  • Minor refactoring.

@mviitane
Fix recommendation logic not to recommend the selected product
672f071 
- There was a fault in the recommendation logic that it offered also the same products which the user just opened (product page) or added to the cart (shopping cart page). The filtering logic not to recommend the same products was fixed.
- Minor refactoring.
@mviitane mviitane requested a review from a team October 8, 2022 14:33
julianocosta89
julianocosta89 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@cartersocha cartersocha merged commit b27fa7d into open-telemetry:main Oct 8, 2022
@mviitane mviitane deleted the recommendations_fix branch October 10, 2022 10:43
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@mviitane
Fix recommendation logic not to recommend the selected product (open-…
00d5b4c 
…telemetry#417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mviitane @julianocosta89 @cartersocha