-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project images #405
Update project images #405
Conversation
I have a different suggestion, although I'm not sure if that's the common practice: Given we don't intend to make modifications on these images, I wonder if they should be kept out of the repo (so we don't need to keep these binaries in the history), and only referenced in the markdown files using some permanent links. For example, all the images in this doc works fine without having to be part of the repo https://github.com/open-telemetry/opentelemetry-cpp/blob/79a9471f5c6462cf5d013331e91f25455f824cd2/examples/prometheus/README.md. |
I think a broken link error is coming from this doc: |
thx @cartersocha, I've missed that one. |
Sounds good @reyang, let me try this. |
Added links and removed files. Thx for the suggestion @reyang! |
Fixes #31 .
Changes
Updated images to reflect the current state of the project.