Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add quoteservice docs #392

Merged
merged 1 commit into from
Sep 29, 2022
Merged

add quoteservice docs #392

merged 1 commit into from
Sep 29, 2022

Conversation

julianocosta89
Copy link
Member

Towards #57.

Changes

  • Added Quote Service (PHP) docs.
  • Added Span Event Attribute just to follow the same approach of other services.

@julianocosta89 julianocosta89 requested a review from a team September 29, 2022 19:33
@julianocosta89
Copy link
Member Author

@bobstrecansky would you mind taking a look?

@julianocosta89 julianocosta89 added the documentation Improvements or additions to documentation label Sep 29, 2022
cartersocha
cartersocha approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cartersocha cartersocha merged commit b7595d6 into open-telemetry:main Sep 29, 2022
@julianocosta89 julianocosta89 deleted the add-quoteservice-documentation branch September 30, 2022 06:34
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
add quoteservice docs (open-telemetry#392)
bcc54ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartersocha cartersocha cartersocha approved these changes

@bobstrecansky bobstrecansky bobstrecansky approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianocosta89 @bobstrecansky @cartersocha