Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[payment] document instrumentation #387

Merged
merged 5 commits into from
Sep 28, 2022
Merged

[payment] document instrumentation #387

merged 5 commits into from
Sep 28, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Sep 27, 2022

Adds documentation for payment service, focused on instrumentation code.

This service makes use of Baggage which should get its own section. I added it after Metrics and Logs which are currently marked TBD. not sure if we go with this or a different approach.

@puckpuck puckpuck requested a review from a team September 27, 2022 02:27
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Only few minor comments.

docs/services/paymentservice.md Outdated Show resolved Hide resolved
docs/services/paymentservice.md Outdated Show resolved Hide resolved
@puckpuck puckpuck merged commit 3a22849 into open-telemetry:main Sep 28, 2022
@puckpuck puckpuck deleted the docs-payment branch September 28, 2022 16:33
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* payment service doc details

* fix spelling

* fix spelling

* spelling/grammar fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants