Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docfx check #385

Merged
merged 1 commit into from
Sep 28, 2022
Merged

remove docfx check #385

merged 1 commit into from
Sep 28, 2022

Conversation

puckpuck
Copy link
Contributor

docfx is failing on relative links to folders. We require these types of links for our service docs.

Per the SIG meeting on 9/26, we determined that the docfx checks were providing no value-add and should be removed. This PR comments out the check (we can remove it completely on a subsequent PR)

@puckpuck puckpuck requested a review from a team September 27, 2022 01:08
@cartersocha
Copy link
Contributor

@puckpuck we might need to remove something in the repo because the docfx check is blocking this pr for not running

@reyang
Copy link
Member

reyang commented Sep 27, 2022

@puckpuck we might need to remove something in the repo because the docfx check is blocking this pr for not running

Maintainers need to remove this from the branch policy:

image

@cartersocha
Copy link
Contributor

@austinlparker youll need to remove the rule. I don’t have permissions to make repo changes like that

@austinlparker
Copy link
Member

I don't have access to branch protection rules; Let me open an issue to have maintainers get admin access.

@reyang
Copy link
Member

reyang commented Sep 28, 2022

I don't have access to branch protection rules; Let me open an issue to have maintainers get admin access.

All maintainers on this project should have access now.

@puckpuck
Copy link
Contributor Author

I removed the branch protection rule that @cartersocha posted a screenshot about, so will merge this now

@puckpuck puckpuck merged commit 79e9996 into open-telemetry:main Sep 28, 2022
@puckpuck puckpuck deleted the remove-docfx-test branch September 28, 2022 16:26
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants