-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove docfx check #385
remove docfx check #385
Conversation
@puckpuck we might need to remove something in the repo because the docfx check is blocking this pr for not running |
Maintainers need to remove this from the branch policy: |
@austinlparker youll need to remove the rule. I don’t have permissions to make repo changes like that |
I don't have access to branch protection rules; Let me open an issue to have maintainers get admin access. |
All maintainers on this project should have access now. |
I removed the branch protection rule that @cartersocha posted a screenshot about, so will merge this now |
docfx is failing on relative links to folders. We require these types of links for our service docs.
Per the SIG meeting on 9/26, we determined that the docfx checks were providing no value-add and should be removed. This PR comments out the check (we can remove it completely on a subsequent PR)