-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traffic to adservice & recommendataion service #368
Add traffic to adservice & recommendataion service #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, why change the recommendationservice
's container_name
though? The main reason why these were added was just for readability of the console logs. Trying to keep consistent hyphenated service name for them
Because of hyphen in container name, the address of container would change . It needs to be consist with ones defined in Line 44 in 860a35d
|
Were you seeing an error? All the other services addresses work and they use the unhyphenated version, which is the actual root name of the service, not the container name. I believe we want to use the service name here, if we scale up to multiple recommendation service containers running at the same time, I think this would only provide traffic to one or completely break if docker compose decides to name them recommendationservice-1 and recommendationservice-2 |
@mic-max Thanks for catching this. I have revert the container name. Initially i was seeing errors during startup of |
Thanks @dineshg13 🙏🏼 |
This PR broke the load generator, primarily through removing locust from requirements.txt. Reverting PR. |
This reverts commit 7484ca8.
…metry#368)" (open-telemetry#375) This reverts commit f428072.
Fixes #360
Changes
Please provide a brief description of the changes here.
docker-compose
PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python
to ensure recommendation-service comes up.After above changes , we are able to see traffic to adservice & recommendation service.