Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkout] document instrumentation #366

Merged
merged 6 commits into from
Sep 22, 2022

Conversation

puckpuck
Copy link
Contributor

Changes

Adds documentation for checkout service, focused on instrumentation code.

Some small non-functional code changes were made to make the docs more presentable and IntelliJ happy.

@puckpuck puckpuck requested a review from a team September 15, 2022 04:23
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @puckpuck!

Copy link
Contributor

@mic-max mic-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nit: Why create this new services directory rather than adding this content to the src/checkoutservice/README.md

@cartersocha
Copy link
Contributor

Not blocking but maybe we can add table of contents to the top of read mes too with links

@austinlparker
Copy link
Member

When you get a sec, please refresh this branch for merge.

@cartersocha cartersocha merged commit 86a0572 into open-telemetry:main Sep 22, 2022
@puckpuck puckpuck deleted the docs-checkout-service branch September 26, 2022 13:49
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants