Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email] span attributes update #334

Merged
merged 3 commits into from
Aug 23, 2022
Merged

[email] span attributes update #334

merged 3 commits into from
Aug 23, 2022

Conversation

puckpuck
Copy link
Contributor

Changes

  • Updates attribute names to be normalized with other services

ref: https://docs.google.com/spreadsheets/d/1cGmYKfl9GAzCnQaG5iP-RoSZ-0R_Nm8hutg-EFotmsE/edit#gid=0

@puckpuck puckpuck requested a review from a team August 23, 2022 03:39
mviitane
mviitane approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@puckpuck puckpuck merged commit 0ca6d9f into open-telemetry:main Aug 23, 2022
@puckpuck puckpuck deleted the email-attributes-update branch August 23, 2022 18:54
@puckpuck puckpuck mentioned this pull request Aug 24, 2022
Closed
3 tasks
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck
[email] span attributes update (open-telemetry#334)
93f87c7 
* update span attributes

* update email span attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mviitane mviitane mviitane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puckpuck @mviitane