Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jaeger as datasource to Grafana #319

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Add jaeger as datasource to Grafana #319

merged 7 commits into from
Aug 23, 2022

Conversation

cedricziel
Copy link
Contributor

This adds jaeger as a datasource for trace data to Grafana when provisioning.

@cedricziel cedricziel requested a review from a team August 18, 2022 10:04
@mviitane
Copy link
Member

Looks good! I think the grafana bullet point in the main README could also be updated to mention traces.

@julianocosta89
Copy link
Member

Any reason why do we need that in this demo?

@cedricziel
Copy link
Contributor Author

@julianocosta89 it's an out of the box feature of Grafana. - It enables viewing traces and metrics side by side and stays in the OpenSource track.

Jaeger is still the main store for the trace data. - Hence I dont think there is an issue adding this. It's lesser a thing we need in the demo, but we get it for free - why not enable it?

@julianocosta89
Copy link
Member

No no... Just wanted to know what was that 😅

As we are already talking, let me ask you one thing.
Is there a way to configure a Grafana dashboard as code?
I'm asking because it would be great if I could see something as soon as I open Grafana UI

@cedricziel
Copy link
Contributor Author

cedricziel commented Aug 22, 2022 •
edited
Loading

Alright :)

Sure thing - Grafana can provision dashboards from file as well - makes sense to add a set of curated dashboards to the demo. https://grafana.com/docs/grafana/latest/administration/provisioning/#dashboards

@cedricziel
Copy link
Contributor Author

I would consider this one finished for now - dashboards would be a separate PR :)

@puckpuck puckpuck merged commit 42956f2 into open-telemetry:main Aug 23, 2022
@cedricziel cedricziel deleted the grafana-jaeger branch August 23, 2022 15:33
@cedricziel cedricziel mentioned this pull request Oct 16, 2023
Closed
6 tasks
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@cedricziel @cartersocha
@reyang @puckpuck
Add jaeger as datasource to Grafana (open-telemetry#319)
e6b03ee 
* Add jaeger as datasource to Grafana

* Update src/grafana/provisioning/datasources/jaeger.yaml

Co-authored-by: Reiley Yang <[email protected]>

* Update src/grafana/provisioning/datasources/default.yaml

Co-authored-by: Reiley Yang <[email protected]>

Co-authored-by: Carter Socha <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Pierre Tessier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cedricziel @mviitane @julianocosta89 @puckpuck @fatsheep9146 @reyang @cartersocha