Readme update #311
Merged
Readme update #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also has solution for gradlew bug issue |
Great improvement! Just one comment that I'd change the title "Local Quickstart" to something without "Local" (I think the Kubernetes part is not really local). It could be, for example: "Getting started". |
|
@cartersocha the collector configuration for the demo when deployed by the helm chart is "hard coded". Changes would be needed in the opentelemetry-demo chart to allow modifying the collector config via the chart's values.yaml. This is would be a welcome change to the chart. |
|
Thanks for the clarification @TylerHelmuth. I’ll create an issue to track this enhancement! |
reyang
reviewed
Aug 17, 2022
reyang
reviewed
Aug 17, 2022
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
reyang
approved these changes
Aug 17, 2022
mviitane
approved these changes
Aug 17, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* simplify * remove screenshots * overhaul main readme * further edits * broken links * links * links * hopefully final links * pr review * Update docs/docker_deployment.md Co-authored-by: Reiley Yang <[email protected]> * Update docs/docker_deployment.md Co-authored-by: Reiley Yang <[email protected]> Co-authored-by: Reiley Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify readme and abstract out info. Docker probably still needs to be updated to reflect docker hub pull guidance.
@mviitane Let me know if you have any structure suggestions.
@wph95 , @TylerHelmuth what would altering the back end collector exporter look like for a helm chart? Is there a straight forward way to slot in a vendor piece like docker?