-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache_to inline and cache_from #304
Conversation
@austinlparker this might help with some of the build times |
Yeah, would certainly help on rebuilds if not initial pull I reckon? |
Rebuilds for sure. I'm not an expert but I think it can help on initial builds too if we connect it to a cache source for images in gchr like Gary refers to. Ideally only the delta in the repo needs to be rebuilt |
I found through some tinkering that we should probably update the .env file when we do releases to ghcr -- otherwise it will not pick up the right version. Otherwise we could put together a makefile that pulls the most recent version of image and then tries to build -- would automatically use the although then people would need |
I mean... you kinda do need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging this a release would be done so to upload the cached version of the images to the docker repository. I think just to be safe here we could try with a single service - I elect the particularly slow shippingservice
(Rust) which will be easy to see the speedup and know the caching worked.
commented out, so we don't have to re-find the implementation later. |
@mic-max are there any changes on this that are pending? shows you still have stuff requested but I don't see it. would like to get this PR updated and merged in. |
@GaryPWhite please update the branch so we can merge! |
anyone know why maintainers cant refresh this branch? weird. waiting on OP to refresh then g2g |
I think it's because some of the upstream repos have branch protections and some sort of access restrictions |
@GaryPWhite just tried this on my mac and it was broken. I'm getting this error: "cache export feature is currently not supported for docker driver. Please switch to a different driver" Any tips? I made sure docker is updated and couldn't find anything specific on Google |
* cache_to inline and cache_from * drop -alpha and update version * comment all but loadservice
Fixes #83.
Changes
Sets up
cache_to
andcache_from
for docker-compose builds. Note that thecache_to
is set toinline
. My best estimation for how we push the cache with a given image up to ghcr is included in the link provided -- there's not much documentation on it from docker directly.Also worth noting -- builds (once cached) are lightning fast!
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes