Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Table layout for manual span attributes #277

Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Aug 9, 2022

Changes

Uses a table layout to list all span attributes by service
Adds a type and description column for each span attribute

Type is restricted to number and string only.

@puckpuck puckpuck requested a review from a team August 9, 2022 04:30
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left couple non-blocking comments/suggestions, the direction looks good to me.

@cartersocha cartersocha merged commit 1a4698f into open-telemetry:main Aug 11, 2022
@puckpuck puckpuck deleted the docs-span-attributes-cleanup branch August 16, 2022 02:26
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants