Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[featureflag] - exclude erlang/elixir build artifacts in makefile #276

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Aug 9, 2022

Changes

When working with the Erlang/Elixir feature flag service, the developer may encounter an error on some make commands.
This PR Excludes the _build and deps build artifact folders from ALL_DOCS in Makefile. Allows developers to run make markdownlint without getting errors on 3rd party readme files downloaded from the Elixir toolchain.

@puckpuck puckpuck requested a review from a team August 9, 2022 04:11
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit 64a4edf into open-telemetry:main Aug 9, 2022
@puckpuck puckpuck deleted the ffs-makefile branch August 10, 2022 02:40
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants